Add pubsub service to notification engine#392
Add pubsub service to notification engine#392KyriosGN0 wants to merge 11 commits intoargoproj:masterfrom
Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
==========================================
+ Coverage 55.41% 57.13% +1.72%
==========================================
Files 46 49 +3
Lines 4125 3782 -343
==========================================
- Hits 2286 2161 -125
+ Misses 1511 1263 -248
- Partials 328 358 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@KyriosGN0 Could you fix conflicts? Also what docs you missing in order to test things? |
|
@pasha-codefresh my main issue is testing locally before i can merge this branch, the docs mention only after i merge this PR, but even then, i can't get argocd to run on my macos |
|
Okay, I see, i will help you with testing |
@pasha-codefresh will you test it yourself or would you help me set up argocd? |
|
hey @pasha-codefresh, have you had the chance to test this ? |
|
hey @pasha-codefresh, any updates? Thanks! |
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
|
@pasha-codefresh i ended up doing a successful test on my local machine, could you please review the PR ? |
This PR adds google pubusb service, similar to AWS SQS
should close #168